Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update CHANGELOG_V10.md #22744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chakravarthysm wants to merge 1 commit into from
Closed

Update CHANGELOG_V10.md #22744

chakravarthysm wants to merge 1 commit into from

Conversation

@chakravarthysm
Copy link

@chakravarthysm chakravarthysm commented Sep 7, 2018

Fix typo

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 7, 2018
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 7, 2018
@targos
Copy link
Member

targos commented Sep 7, 2018

Thanks! The blog post should also be updated in the website's repo

@addaleax
Copy link
Member

addaleax commented Sep 7, 2018

Landed in e638bc5, thanks for the PR!

@addaleax addaleax closed this Sep 7, 2018
addaleax pushed a commit that referenced this pull request Sep 7, 2018
@chakravarthy-s-m @addaleax
doc: fix typo in CHANGELOG_V10.md
e638bc5 
Fix typo

PR-URL: #22744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 7, 2018
@chakravarthy-s-m @targos
doc: fix typo in CHANGELOG_V10.md
e5cdfb0 
Fix typo

PR-URL: #22744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+2 more reviewers

@hiroppy hiroppy hiroppy approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.