Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@refack
Copy link
Contributor

@refack refack commented Aug 23, 2018

Fix a regression introduced by #22399

Please 馃憤 for fast tracking.

Ref: #22399 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@refack refack added tools Issues and PRs related to the tools directory. regression Issues related to regressions. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 23, 2018
@refack refack requested review from addaleax and joyeecheung August 23, 2018 15:22
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 23, 2018
@refack refack force-pushed the fix-format-cpp-build branch from 8064a1c to 21f38c7 Compare August 23, 2018 15:23
@refack refack changed the title Fix format cpp build tools: fix make format-cpp-build Aug 23, 2018
@refack
Copy link
Contributor Author

refack commented Aug 23, 2018

/CC @nodejs/build-files @nodejs/linting

@refack
Copy link
Contributor Author

refack commented Aug 24, 2018

Closing in favor of #22500

@refack refack closed this Aug 24, 2018
@refack refack deleted the fix-format-cpp-build branch August 24, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.