Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

tools,test: remove unused config hooks #22010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maclover7 wants to merge 1 commit into from
Closed

tools,test: remove unused config hooks #22010

maclover7 wants to merge 1 commit into from

Conversation

@maclover7
Copy link
Contributor

@maclover7 maclover7 commented Jul 28, 2018

Removes a couple of unused/empty functions inside of tools/test.py

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@maclover7
tools,test: remove unused config hooks
e174910 
Removes a couple of unused/empty functions inside of `tools/test.py`
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 28, 2018

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/372/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 28, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 29, 2018
@maclover7
Copy link
Contributor Author

maclover7 commented Jul 29, 2018

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16063/

@maclover7
Copy link
Contributor Author

maclover7 commented Jul 30, 2018

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/16081/

@maclover7
Copy link
Contributor Author

maclover7 commented Jul 31, 2018 •
edited
Loading

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19567/ (edit: ✔️)

@maclover7
Copy link
Contributor Author

maclover7 commented Jul 31, 2018

Landed in 3b23b4d

@maclover7 maclover7 closed this Jul 31, 2018
@maclover7 maclover7 deleted the jm-unused-test branch July 31, 2018 14:36
maclover7 added a commit that referenced this pull request Jul 31, 2018
@maclover7
tools,test: remove unused config hooks
3b23b4d 
Removes a couple of unused/empty functions inside of `tools/test.py`

PR-URL: #22010
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 1, 2018
@maclover7 @targos
tools,test: remove unused config hooks
02e665c 
Removes a couple of unused/empty functions inside of `tools/test.py`

PR-URL: #22010
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 1, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maclover7 @nodejs-github-bot @jasnell @BridgeAR
Morty Proxy This is a proxified and sanitized view of the page, visit original site.