n-api: fix compiler warning #21597
Merged
n-api: fix compiler warning #21597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM; but: @gabrielschulhof I thought you added async context tracking? I’m not sure where that’s being propagated here… |
Contributor
|
@addaleax I believe I simply forgot to remove that field when |
gabrielschulhof
approved these changes
Jun 30, 2018
danbev
approved these changes
Jul 1, 2018
Contributor
Contributor
node-test-commit-windows-fanned failure looks unrelated09:30:47 not ok 566 sequential/test-inspector-break-when-eval
09:30:47 ---
09:30:47 duration_ms: 0.403
09:30:47 severity: fail
09:30:47 exitcode: 1
09:30:47 stack: |-
09:30:47 [test] Connecting to a child Node process
09:30:47 [test] Testing /json/list
09:30:47 [err] Debugger listening on ws://127.0.0.1:61103/56a876e9-c99e-4083-961c-f8ff452a4e8d
09:30:47 [err] For help, see: https://nodejs.org/en/docs/inspector
09:30:47 [err]
09:30:47 [out] Ready!
09:30:47 [out]
09:30:47 [test] Setting up a debugger
09:30:47 [test] Breaking in the code
09:30:47 [test] Step over console statement and test output
09:30:47 [out] 0 3
09:30:47 [out]
09:30:47 [test] Verify node waits for the frontend to disconnect
09:30:47 [err] Debugger attached.
09:30:47 [err] Waiting for the debugger to disconnect...
09:30:47 [err]
09:30:47 { AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
09:30:47 + expected - actual
09:30:47
09:30:47 - 0
09:30:47 + 3221225477
09:30:47 at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-break-when-eval.js:65:10)
09:30:47 at process._tickCallback (internal/process/next_tick.js:68:7)
09:30:47 generatedMessage: true,
09:30:47 name: 'AssertionError [ERR_ASSERTION]',
09:30:47 code: 'ERR_ASSERTION',
09:30:47 actual: 0,
09:30:47 expected: 3221225477,
09:30:47 operator: 'strictEqual' }
09:30:47 1
09:30:47 ... |
private field 'async_context' is not used [-Wunused-private-field] PR-URL: nodejs#21597 Refs: nodejs#17887 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Dec 28, 2018
private field 'async_context' is not used [-Wunused-private-field] PR-URL: nodejs#21597 Refs: nodejs#17887 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
private field 'async_context' is not used [-Wunused-private-field]
Refs: #17887
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes