Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

doc: update pull request template in the contributing guide #20277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hackzzila wants to merge 1 commit into from
Closed

doc: update pull request template in the contributing guide #20277

Hackzzila wants to merge 1 commit into from

Conversation

@Hackzzila
Copy link
Contributor

@Hackzzila Hackzzila commented Apr 25, 2018

Refs: #19125

Updates the Pull Request template in the contributing guide to be consistent with .github/PULL_REQUEST_TEMPLATE.md

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 25, 2018
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 25, 2018

Please, add 👍 here to approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 25, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/584/

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Apr 25, 2018
@tniessen
Copy link
Member

tniessen commented Apr 25, 2018

Landed in a3231d9, thank you!

@tniessen tniessen closed this Apr 25, 2018
tniessen pushed a commit that referenced this pull request Apr 25, 2018
@Hackzzila @tniessen
doc: update pull request template in guide
a3231d9 
PR-URL: #20277
Refs: #19125
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Hackzzila Hackzzila deleted the patch-3 branch April 25, 2018 14:52
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@Hackzzila @MylesBorins
doc: update pull request template in guide
3bf736e 
PR-URL: #20277
Refs: #19125
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hackzzila @vsemozhetbyt @tniessen @lpinca @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.