[v9.x backport] lib: rename js source to lower snake_case #19969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
TimothyGu
approved these changes
Apr 28, 2018
Member
TimothyGu
left a comment
There was a problem hiding this comment.
LGTM, but this now has a conflict.
This commit renames all JavaScript source files in lib to lower snake_case. PR-URL: nodejs#19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
bd20b6f to
f1326ec
Compare
Contributor
Author
Member
|
Landed in 679f362 |
targos
pushed a commit
that referenced
this pull request
Jun 6, 2018
This commit renames all JavaScript source files in lib to lower snake_case. Backport-PR-URL: #19969 PR-URL: #19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames all JavaScript source files in lib to lower
snake_case.
PR-URL: #19556
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Tiancheng "Timothy" Gu timothygu99@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes