Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: replace Function with Arrow Function to test-http-pause.js #17306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kjunichi wants to merge 1 commit into from
Closed

test: replace Function with Arrow Function to test-http-pause.js #17306

kjunichi wants to merge 1 commit into from

Conversation

@kjunichi
Copy link
Contributor

@kjunichi kjunichi commented Nov 26, 2017

This is part of Nodefest's Code and Learn nodejs/code-and-learn#72

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 26, 2017
@hiroppy hiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 26, 2017
@yosuke-furukawa
Copy link
Member

yosuke-furukawa commented Nov 26, 2017

Please remove your package-lock.json

@MylesBorins MylesBorins mentioned this pull request Nov 26, 2017
Closed
@maclover7
Copy link
Contributor

maclover7 commented Nov 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11727/

@gibfahn gibfahn mentioned this pull request Nov 26, 2017
Closed
@kjunichi
Copy link
Contributor Author

kjunichi commented Nov 27, 2017 •
edited
Loading

sorry for late reply.

@yosuke-furukawa thank you for your advise.

I've removed follwing files:

  • tools/remark-cli/package-lock.json
  • tools/remark-preset-lint-node/package-lock.json

But it seems CI is not OK.
What shoud I do?

@maclover7
Copy link
Contributor

maclover7 commented Nov 28, 2017

@kjunichi No worries -- it looks like linuxone hit a random failure -- rerunning at https://ci.nodejs.org/job/node-test-commit-linuxone/10706/nodes=rhel72-s390x, and then should be good to land :)

@maclover7
Copy link
Contributor

maclover7 commented Nov 28, 2017

Yup, random failure -- CI is all green, landing...

@maclover7 maclover7 self-assigned this Nov 28, 2017
maclover7 pushed a commit that referenced this pull request Nov 28, 2017
@kjunichi @maclover7
test: replace function with ES6 arrow function
a177708 
PR-URL: #17306
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@maclover7
Copy link
Contributor

maclover7 commented Nov 28, 2017

Landed in a177708, congrats on your first PR to Node.js!
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Nov 28, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@kjunichi @MylesBorins
test: replace function with ES6 arrow function
b39a4ad 
PR-URL: #17306
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@kjunichi @MylesBorins
test: replace function with ES6 arrow function
7379af5 
PR-URL: #17306
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@kjunichi @MylesBorins
test: replace function with ES6 arrow function
71eb186 
PR-URL: #17306
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@kjunichi @gibfahn
test: replace function with ES6 arrow function
f5a2cff 
PR-URL: #17306
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@kjunichi @gibfahn
test: replace function with ES6 arrow function
4f3a165 
PR-URL: #17306
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@kjunichi @gibfahn
test: replace function with ES6 arrow function
ef72610 
PR-URL: #17306
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@watilde watilde watilde approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+2 more reviewers

@maclover7 maclover7 maclover7 approved these changes

@hiroppy hiroppy hiroppy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maclover7 maclover7

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.