change common with fixtures as task of nodetodo #16809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@DeltaLikeM - looks like you pushed changed without: on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again? |
test/parallel/test-repl.js
Outdated
| @@ -40,7 +41,7 @@ let server_tcp, server_unix, client_tcp, client_unix, replServer; | ||
|
|
||
|
|
||
| // absolute path to test/fixtures/a.js | ||
| const moduleFilename = require('path').join(common.fixturesDir, 'a'); | ||
| const moduleFilename = require('path').join(fixtures.fixturesDir, 'a'); | ||
|
|
Member
There was a problem hiding this comment.
this can be:
const moduleFilename = fixtures.path('a');
f7fa5cd to
ec8d9ca
Compare
Member
Contributor
|
Beware: Commit author is not associated with the GitHub account. @DeltaLikeM Can you add the local email to your GitHub account email list? See the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
vsemozhetbyt
reviewed
Nov 6, 2017
test/parallel/test-repl.js
Outdated
| @@ -21,6 +21,7 @@ | ||
|
|
||
| 'use strict'; | ||
| const common = require('../common'); | ||
| const fixtures = require('../common/fixtures') |
Contributor
There was a problem hiding this comment.
A linter nit: missing semicolon.
Member
Trott
approved these changes
Nov 6, 2017
gireeshpunathil
approved these changes
Nov 7, 2017
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 7, 2017
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Landed in ac1e6bd , thanks! |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
PR-URL: nodejs#16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)