build: disable -Og when building with clang #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
clang does not yet support -Og, fall back to -O0. See: https://llvm.org/bugs/show_bug.cgi?id=20765 Fixes: nodejs#1608 PR-URL: nodejs#1609 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
f9ea440 to
e67542a
Compare
This was referenced Apr 25, 2023
This was referenced Apr 26, 2023
This was referenced Apr 27, 2023
This was referenced Jun 21, 2023
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Apr 15, 2024
This was referenced Apr 16, 2024
This was referenced May 13, 2024
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang does not yet support -Og, fall back to -O0.
Fixes: #1608
See: https://llvm.org/bugs/show_bug.cgi?id=20765
R=@Fishrock123?