Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fs: validate fd on fs.write #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julianduque wants to merge 1 commit into from
Closed

fs: validate fd on fs.write #1553

julianduque wants to merge 1 commit into from

Conversation

@julianduque
Copy link
Contributor

@julianduque julianduque commented Apr 28, 2015

This PR fixes #1550

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Apr 28, 2015
cjihrig
cjihrig reviewed Apr 28, 2015
View reviewed changes
src/node_file.cc Outdated
Copy link
Contributor

@cjihrig cjihrig Apr 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check still required?

@julianduque
Copy link
Contributor Author

julianduque commented Apr 28, 2015

@cjihrig fixed PR with your suggestions

@cjihrig
Copy link
Contributor

cjihrig commented Apr 28, 2015

LGTM

julianduque added a commit that referenced this pull request Apr 28, 2015
@julianduque
fs: validate fd on fs.write
f9c681c 
PR-URL: #1553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@julianduque
Copy link
Contributor Author

julianduque commented Apr 28, 2015

Landed in f9c681c

@julianduque julianduque deleted the fix-fs-write branch April 28, 2015 22:47
@rvagg rvagg mentioned this pull request Apr 29, 2015
Closed
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Apr 29, 2015
@julianduque @Fishrock123
fs: validate fd on fs.write
120cf35 
PR-URL: nodejs#1553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 14, 2015
@julianduque @Fishrock123
fs: validate fd on fs.write
4030545 
PR-URL: nodejs#1553
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / f9c681c
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request May 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.write crashes on non-integer fd

3 participants

@julianduque @cjihrig @mscdex
Morty Proxy This is a proxified and sanitized view of the page, visit original site.