docs: fix Buffer.allocUnsafeSlow is added in 5.12.0 instead of 5.10.0 #15330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 12, 2017
richardlau
approved these changes
Sep 12, 2017
cjihrig
approved these changes
Sep 12, 2017
lpinca
approved these changes
Sep 12, 2017
4 tasks
Contributor
|
Basing on this comment in identical PR, landed in 0dad97c |
Contributor
|
@tuananh Thank you for the contribution! |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
PR-URL: nodejs/node#15330 Fixes: nodejs/node#15279 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#15330 Fixes: nodejs/node#15279 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating docs: Buffer.allocUnsafeSlow() is added in v5.12.0 instead of 5.10.0
Fixed: #15279
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
None