Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

src: add .FromJust(), fix -Wunused-result warnings #12118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 1 commit into from
+3 −3
Closed

src: add .FromJust(), fix -Wunused-result warnings #12118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: add .FromJust(), fix -Wunused-result warnings 
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")
  • Loading branch information
@bnoordhuis
bnoordhuis committed Mar 29, 2017
commit a4c152de6e3a4f1f42e9e7d5f8f545bc4636a622
6 changes: 3 additions & 3 deletions 6 src/node_serdes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ DeserializerContext::DeserializerContext(Environment* env,
data_(reinterpret_cast<const uint8_t*>(Buffer::Data(buffer))),
length_(Buffer::Length(buffer)),
deserializer_(env->isolate(), data_, length_, this) {
object()->Set(env->context(), env->buffer_string(), buffer);
object()->Set(env->context(), env->buffer_string(), buffer).FromJust();

MakeWeak<DeserializerContext>(this);
}
Expand Down Expand Up @@ -388,8 +388,8 @@ void DeserializerContext::ReadUint64(const FunctionCallbackInfo<Value>& args) {
Local<Context> context = ctx->env()->context();

Local<Array> ret = Array::New(isolate, 2);
ret->Set(context, 0, Integer::NewFromUnsigned(isolate, hi));
ret->Set(context, 1, Integer::NewFromUnsigned(isolate, lo));
ret->Set(context, 0, Integer::NewFromUnsigned(isolate, hi)).FromJust();
ret->Set(context, 1, Integer::NewFromUnsigned(isolate, lo)).FromJust();
return args.GetReturnValue().Set(ret);
}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.