Bring back default parameter

nodejs · TimothyGu · Jan 28, 2017 · Jan 28, 2017 · Jan 28, 2017 · Jan 29, 2017
commit 28130631bd09aaf7988adcdf1b5b5e7031e15c5a
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -648,7 +648,11 @@ function getObjectFromParams(array) {
 }

 class URLSearchParams {
-  constructor(init) {
+  // URL Standard says the default value is '', but as undefined and '' have
+  // the same result, undefined is used to prevent unnecessary parsing.
+  // Default parameter is necessary to keep URLSearchParams.length === 0 in
+  // accordance with Web IDL spec.
+  constructor(init = undefined) {
    if (init === null || init === undefined) {
      this[searchParams] = [];
    } else if (typeof init === 'object') {
-Original file line number
+Diff line change
@@ -648,7 +648,11 @@ function getObjectFromParams(array) {
     }
     class URLSearchParams {
-      constructor(init) {
+      // URL Standard says the default value is '', but as undefined and '' have
+      // the same result, undefined is used to prevent unnecessary parsing.
+      // Default parameter is necessary to keep URLSearchParams.length === 0 in
+      // accordance with Web IDL spec.
+      constructor(init = undefined) {
         if (init === null || init === undefined) {
               Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
  Member


        

    
  

  
    
      
          
      

      
            joyeecheung
  

      

      

      


        Jan 29, 2017


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      If we have init = '' as default then init can't be undefined?
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    


      



    
        
  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
  Member


        

  Author


    
  

  
    
      
          
      

      
            TimothyGu
  

      

      

      


        Jan 29, 2017


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      The user can do new URLSearchParams(undefined). The default is there to echo the = "" in the spec, though now I agree it's a bit pointless.
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
           this[searchParams] = [];
         } else if (typeof init === 'object') {
-          Expand Down