Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 20, 2017

This commit adds a description of the NODE_NO_WARNINGS environment variable to the --help output. This was overlooked in 4990212.

Refs: #10842

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src

CI: https://ci.nodejs.org/job/node-test-pull-request/5997/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v7.x labels Jan 20, 2017
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 23, 2017

The CI failure seems infrastructure related, and this is a trivial change. Landing.

@cjihrig cjihrig merged commit f69e59d into nodejs:master Jan 23, 2017
@cjihrig cjihrig deleted the help branch January 23, 2017 16:39
targos pushed a commit that referenced this pull request Jan 28, 2017
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: #10842
PR-URL: #10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: #10842
PR-URL: #10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: #10842
PR-URL: #10918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.