Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test test-child-process-stdin.js: change assert.ok to assert.strictEqual #10418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
navulirs wants to merge 1 commit into from
Closed

test test-child-process-stdin.js: change assert.ok to assert.strictEqual #10418

navulirs wants to merge 1 commit into from

Conversation

@navulirs
Copy link
Contributor

@navulirs navulirs commented Dec 22, 2016

test test-child-process-stdin.js: change assert.ok to assert.strictEqual

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 22, 2016
italoacasas
italoacasas suggested changes Dec 23, 2016
View reviewed changes
Copy link

@italoacasas italoacasas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sriluvan we have two assert.equal() in line 37 and 39, would you mind updating those too?

@navulirs
Copy link
Contributor Author

navulirs commented Dec 23, 2016

Definitely. In another few minutes.

@italoacasas
Copy link

italoacasas commented Dec 23, 2016

@sriluvan sorry my bad, I see another PR with that changes #10022, why you don't make this changes in the original PR ?

@navulirs
Copy link
Contributor Author

navulirs commented Dec 23, 2016

Ok. Didn't know I can update a open PR. will do it this time.

@italoacasas
Copy link

italoacasas commented Dec 23, 2016 •
edited
Loading

Yes you can update your PR, add a commit with the changes in the same branch, squash and then use the --force flag, ask me if you have any question in the process

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 23, 2016
@navulirs
Copy link
Contributor Author

navulirs commented Dec 23, 2016

I did like you suggested

After commit executed this -

Git push --force origin sriluvan

Got message everything up-to-date

Let me know if you don't see my changes

@italoacasas
Copy link

italoacasas commented Dec 23, 2016 •
edited
Loading

I don't see your changes, the process should be:

1 - change to the branch test-fix -> PR #10022
2 - make this changes in that branch
3 - git add and git commit
4 - git push --force origin test-fix

@Trott
Copy link
Member

Trott commented Dec 24, 2016

Closing in favor of #10420

@Trott Trott closed this Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@italoacasas italoacasas italoacasas requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@navulirs @italoacasas @Trott @cjihrig @mscdex @MylesBorins @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.