test: use strictEqual in test-debug-break #10181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use strictEqual assertions in test-debug-break-on-uncaught.js
cjihrig
approved these changes
Dec 9, 2016
italoacasas
approved these changes
Dec 9, 2016
thefourtheye
approved these changes
Dec 9, 2016
Member
Member
Author
|
@lance could you please check what happened with the CI? |
italoacasas
pushed a commit
that referenced
this pull request
Dec 13, 2016
use strictEqual assertions in test-debug-break-on-uncaught.js PR-URL: #10181 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
CI issue was not because of the test. I try again and all green. Landed 3b2a630 |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
use strictEqual assertions in test-debug-break-on-uncaught.js PR-URL: #10181 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
Contributor
|
these tests are stalling on v4 and v6, as such I am opting to not land them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
use strictEqual assertions in test-debug-break-on-uncaught.js