Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ff9232d

Browse filesBrowse files
James IrwinMylesBorins
authored andcommitted
test: correct order of args in buffer compare
PR-URL: #23521 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent d862f1e commit ff9232d
Copy full SHA for ff9232d

File tree

Expand file treeCollapse file tree

1 file changed

+20
-20
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+20
-20
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-buffer-compare-offset.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-buffer-compare-offset.js
+20-20Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,56 +6,56 @@ const assert = require('assert');
66
const a = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 0]);
77
const b = Buffer.from([5, 6, 7, 8, 9, 0, 1, 2, 3, 4]);
88

9-
assert.strictEqual(-1, a.compare(b));
9+
assert.strictEqual(a.compare(b), -1);
1010

1111
// Equivalent to a.compare(b).
12-
assert.strictEqual(-1, a.compare(b, 0));
13-
assert.strictEqual(-1, a.compare(b, '0'));
14-
assert.strictEqual(-1, a.compare(b, undefined));
12+
assert.strictEqual(a.compare(b, 0), -1);
13+
assert.strictEqual(a.compare(b, '0'), -1);
14+
assert.strictEqual(a.compare(b, undefined), -1);
1515

1616
// Equivalent to a.compare(b).
17-
assert.strictEqual(-1, a.compare(b, 0, undefined, 0));
17+
assert.strictEqual(a.compare(b, 0, undefined, 0), -1);
1818

1919
// Zero-length target, return 1
20-
assert.strictEqual(1, a.compare(b, 0, 0, 0));
21-
assert.strictEqual(1, a.compare(b, '0', '0', '0'));
20+
assert.strictEqual(a.compare(b, 0, 0, 0), 1);
21+
assert.strictEqual(a.compare(b, '0', '0', '0'), 1);
2222

2323
// Equivalent to Buffer.compare(a, b.slice(6, 10))
24-
assert.strictEqual(1, a.compare(b, 6, 10));
24+
assert.strictEqual(a.compare(b, 6, 10), 1);
2525

2626
// Zero-length source, return -1
27-
assert.strictEqual(-1, a.compare(b, 6, 10, 0, 0));
27+
assert.strictEqual(a.compare(b, 6, 10, 0, 0), -1);
2828

2929
// Zero-length source and target, return 0
30-
assert.strictEqual(0, a.compare(b, 0, 0, 0, 0));
31-
assert.strictEqual(0, a.compare(b, 1, 1, 2, 2));
30+
assert.strictEqual(a.compare(b, 0, 0, 0, 0), 0);
31+
assert.strictEqual(a.compare(b, 1, 1, 2, 2), 0);
3232

3333
// Equivalent to Buffer.compare(a.slice(4), b.slice(0, 5))
34-
assert.strictEqual(1, a.compare(b, 0, 5, 4));
34+
assert.strictEqual(a.compare(b, 0, 5, 4), 1);
3535

3636
// Equivalent to Buffer.compare(a.slice(1), b.slice(5))
37-
assert.strictEqual(1, a.compare(b, 5, undefined, 1));
37+
assert.strictEqual(a.compare(b, 5, undefined, 1), 1);
3838

3939
// Equivalent to Buffer.compare(a.slice(2), b.slice(2, 4))
40-
assert.strictEqual(-1, a.compare(b, 2, 4, 2));
40+
assert.strictEqual(a.compare(b, 2, 4, 2), -1);
4141

4242
// Equivalent to Buffer.compare(a.slice(4), b.slice(0, 7))
43-
assert.strictEqual(-1, a.compare(b, 0, 7, 4));
43+
assert.strictEqual(a.compare(b, 0, 7, 4), -1);
4444

4545
// Equivalent to Buffer.compare(a.slice(4, 6), b.slice(0, 7));
46-
assert.strictEqual(-1, a.compare(b, 0, 7, 4, 6));
46+
assert.strictEqual(a.compare(b, 0, 7, 4, 6), -1);
4747

4848
// zero length target
49-
assert.strictEqual(1, a.compare(b, 0, null));
49+
assert.strictEqual(a.compare(b, 0, null), 1);
5050

5151
// coerces to targetEnd == 5
52-
assert.strictEqual(-1, a.compare(b, 0, { valueOf: () => 5 }));
52+
assert.strictEqual(a.compare(b, 0, { valueOf: () => 5 }), -1);
5353

5454
// zero length target
55-
assert.strictEqual(1, a.compare(b, Infinity, -Infinity));
55+
assert.strictEqual(a.compare(b, Infinity, -Infinity), 1);
5656

5757
// zero length target because default for targetEnd <= targetSource
58-
assert.strictEqual(1, a.compare(b, '0xff'));
58+
assert.strictEqual(a.compare(b, '0xff'), 1);
5959

6060
const oor = common.expectsError({ code: 'ERR_INDEX_OUT_OF_RANGE' }, 7);
6161

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.