Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ff3b7d2

Browse filesBrowse files
codebyteretargos
authored andcommitted
src: ensure V8 initialized before marking milestone
PR-URL: #40405 Refs: electron/electron#31349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 618bbbf commit ff3b7d2
Copy full SHA for ff3b7d2

File tree

Expand file treeCollapse file tree

1 file changed

+5
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-2
lines changed
Open diff view settings
Collapse file

‎src/env.cc‎

Copy file name to clipboardExpand all lines: src/env.cc
+5-2Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -458,8 +458,11 @@ void Environment::InitializeMainContext(Local<Context> context,
458458
environment_start_time_);
459459
performance_state_->Mark(performance::NODE_PERFORMANCE_MILESTONE_NODE_START,
460460
per_process::node_start_time);
461-
performance_state_->Mark(performance::NODE_PERFORMANCE_MILESTONE_V8_START,
462-
performance::performance_v8_start);
461+
462+
if (per_process::v8_initialized) {
463+
performance_state_->Mark(performance::NODE_PERFORMANCE_MILESTONE_V8_START,
464+
performance::performance_v8_start);
465+
}
463466
}
464467

465468
Environment::~Environment() {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.