Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fefa57a

Browse filesBrowse files
TimothyGutargos
authored andcommitted
crypto: remove outdated comment
PR-URL: #21511 Fixes: #21488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent dad7821 commit fefa57a
Copy full SHA for fefa57a

File tree

Expand file treeCollapse file tree

1 file changed

+0
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-3
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2154,9 +2154,6 @@ void SSLWrap<Base>::VerifyError(const FunctionCallbackInfo<Value>& args) {
21542154
if (x509_verify_error == X509_V_OK)
21552155
return args.GetReturnValue().SetNull();
21562156

2157-
// XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe
2158-
// in the presence of invalid error codes. Probably academical but something
2159-
// to keep in mind if/when node ever grows multi-isolate capabilities.
21602157
const char* reason = X509_verify_cert_error_string(x509_verify_error);
21612158
const char* code = reason;
21622159
#define CASE_X509_ERR(CODE) case X509_V_ERR_##CODE: code = #CODE; break;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.