Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fe9b6ee

Browse filesBrowse files
danbevaddaleax
authored andcommitted
test: move require('https') to after crypto check
Currently, test-https-client-override-global-agent.js fails with the following error when configured --without-ssl: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:101:11) ... at Object.<anonymous> (/node/test/parallel/test-https-client-override-global-agent.js:5:15) This commit moves the require statement to after the crypto check. PR-URL: #25388 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent dcbf1d9 commit fe9b6ee
Copy full SHA for fe9b6ee

File tree

Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-https-client-override-global-agent.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-https-client-override-global-agent.js
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
'use strict';
22
const common = require('../common');
3+
if (!common.hasCrypto)
4+
common.skip('missing crypto');
35
const fixtures = require('../common/fixtures');
46
const assert = require('assert');
57
const https = require('https');
68

7-
if (!common.hasCrypto)
8-
common.skip('missing crypto');
9-
109
// Disable strict server certificate validation by the client
1110
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
1211

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.