Commit fd4d1e2
http2: remove square brackets from parsed hostname
Make `http2.connect()` work when using URLs with literal IPv6
addresses.
Fixes: #28216
PR-URL: #28406
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>1 parent 0111c61 commit fd4d1e2Copy full SHA for fd4d1e2
File tree
Expand file treeCollapse file tree
2 files changed
+39
-2
lines changedOpen diff view settings
Filter options
- lib/internal/http2
- test/parallel
Expand file treeCollapse file tree
2 files changed
+39
-2
lines changedOpen diff view settings
Collapse file
+10-1Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2782 | 2782 | |
2783 | 2783 | |
2784 | 2784 | |
2785 | | - |
| 2785 | + |
| 2786 | + |
| 2787 | + |
| 2788 | + |
| 2789 | + |
| 2790 | + |
| 2791 | + |
| 2792 | + |
| 2793 | + |
| 2794 | + |
2786 | 2795 | |
2787 | 2796 | |
2788 | 2797 | |
|
Collapse file
test/parallel/test-http2-connect.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-connect.js+29-1Lines changed: 29 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | | - |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
4 | 10 | |
5 | 11 | |
6 | 12 | |
| ||
73 | 79 | |
74 | 80 | |
75 | 81 | |
| 82 | + |
| 83 | + |
| 84 | + |
| 85 | + |
| 86 | + |
| 87 | + |
| 88 | + |
| 89 | + |
| 90 | + |
| 91 | + |
| 92 | + |
| 93 | + |
| 94 | + |
| 95 | + |
| 96 | + |
| 97 | + |
| 98 | + |
| 99 | + |
| 100 | + |
| 101 | + |
| 102 | + |
| 103 | + |
0 commit comments