Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fcaa2c8

Browse filesBrowse files
joyeecheungaduh95
authored andcommitted
build: fix GN build on macOS
use_gold is not defined on macOS. PR-URL: #56141 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent cfbdff7 commit fcaa2c8
Copy full SHA for fcaa2c8

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎unofficial.gni‎

Copy file name to clipboardExpand all lines: unofficial.gni
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ template("node_gn_build") {
263263
ldflags = [ "/OPT:NOICF" ] # link.exe, but also lld-link.exe.
264264
} else if (is_apple && !use_lld) {
265265
ldflags = [ "-Wl,-no_deduplicate" ] # ld64.
266-
} else if (use_gold || use_lld) {
266+
} else if ((!is_apple && use_gold) || use_lld) {
267267
ldflags = [ "-Wl,--icf=none" ]
268268
}
269269
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.