Commit fc6ee39
tools: fix custom eslint rule errors
This fixes a few rules by making sure the input is actually ready
to be checked. Otherwise those can throw TypeErrors or result in
faulty error messages.
PR-URL: #18853
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 38797b5 commit fc6ee39Copy full SHA for fc6ee39
File tree
Expand file treeCollapse file tree
4 files changed
+15
-23
lines changedOpen diff view settings
Filter options
- tools/eslint-rules
Expand file treeCollapse file tree
4 files changed
+15
-23
lines changedOpen diff view settings
Collapse file
tools/eslint-rules/alphabetize-errors.js
Copy file name to clipboardExpand all lines: tools/eslint-rules/alphabetize-errors.js+2-7Lines changed: 2 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
| 3 | + |
| 4 | + |
3 | 5 | |
4 | 6 | |
5 | 7 | |
6 | 8 | |
7 | 9 | |
8 | 10 | |
9 | 11 | |
10 | | - |
11 | | - |
12 | | - |
13 | | - |
14 | | - |
15 | | - |
16 | | - |
17 | 12 | |
18 | 13 | |
19 | 14 | |
|
Collapse file
tools/eslint-rules/documented-errors.js
Copy file name to clipboardExpand all lines: tools/eslint-rules/documented-errors.js+2-8Lines changed: 2 additions & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2 | 2 | |
3 | 3 | |
4 | 4 | |
| 5 | + |
5 | 6 | |
6 | 7 | |
7 | 8 | |
| ||
18 | 19 | |
19 | 20 | |
20 | 21 | |
21 | | - |
22 | | - |
23 | | - |
24 | | - |
25 | | - |
26 | | - |
27 | | - |
28 | 22 | |
29 | 23 | |
30 | 24 | |
31 | 25 | |
32 | | - |
| 26 | + |
33 | 27 | |
34 | 28 | |
35 | 29 | |
|
Collapse file
tools/eslint-rules/prefer-util-format-errors.js
Copy file name to clipboardExpand all lines: tools/eslint-rules/prefer-util-format-errors.js+3-8Lines changed: 3 additions & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
| 3 | + |
| 4 | + |
3 | 5 | |
4 | 6 | |
5 | 7 | |
| ||
8 | 10 | |
9 | 11 | |
10 | 12 | |
11 | | - |
12 | | - |
13 | | - |
14 | | - |
15 | | - |
16 | | - |
17 | | - |
18 | 13 | |
19 | 14 | |
20 | 15 | |
21 | 16 | |
22 | | - |
| 17 | + |
23 | 18 | |
24 | 19 | |
25 | 20 | |
|
Collapse file
tools/eslint-rules/rules-utils.js
Copy file name to clipboardExpand all lines: tools/eslint-rules/rules-utils.js+8Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3 | 3 | |
4 | 4 | |
5 | 5 | |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
6 | 14 | |
7 | 15 | |
8 | 16 | |
|
0 commit comments