Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fb615bd

Browse filesBrowse files
pgeissMyles Borins
authored andcommitted
buffer: remove unnecessary TODO comments
Refs: #4642 PR-URL: #4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 91066b5 commit fb615bd
Copy full SHA for fb615bd

File tree

Expand file treeCollapse file tree

1 file changed

+0
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-5
lines changed
Open diff view settings
Collapse file

‎lib/buffer.js‎

Copy file name to clipboardExpand all lines: lib/buffer.js
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -513,9 +513,6 @@ Buffer.prototype.set = internalUtil.deprecate(function set(offset, v) {
513513
return this[offset] = v;
514514
}, 'Buffer.set is deprecated. Use array indexes instead.');
515515

516-
517-
// TODO(trevnorris): fix these checks to follow new standard
518-
// write(string, offset = 0, length = buffer.length, encoding = 'utf8')
519516
var writeWarned = false;
520517
const writeMsg = 'Buffer.write(string, encoding, offset, length) is ' +
521518
'deprecated. Use write(string[, offset[, length]]' +
@@ -608,8 +605,6 @@ Buffer.prototype.toJSON = function() {
608605
};
609606

610607

611-
// TODO(trevnorris): currently works like Array.prototype.slice(), which
612-
// doesn't follow the new standard for throwing on out of range indexes.
613608
Buffer.prototype.slice = function slice(start, end) {
614609
const buffer = this.subarray(start, end);
615610
Object.setPrototypeOf(buffer, Buffer.prototype);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.