Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit faf8ada

Browse filesBrowse files
richardlautargos
richardlau
authored and
targos
committed
deps: V8: cherry-pick f6bef09b3b0a
Original commit message: [turboshaft] initialize constant_value_ to an empty value gcc-10 seems to have a bug were not initializing this value throws this compilation error: ``` src/compiler/turboshaft/assembler.h:680:16: error: ‘<anonymous>’ is used uninitialized in this function [-Werror=uninitialized] 680 | return Get(); ``` https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86465 Bug: v8:12783 Change-Id: I7a5fee5009b866a801326fba734c156c3cfdb1b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5503350 Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#93675} Refs: v8/v8@f6bef09 PR-URL: #52802 Fixes: #52661 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
1 parent 850ff02 commit faf8ada
Copy full SHA for faf8ada

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.11',
40+
'v8_embedder_string': '-node.12',
4141

4242
##### V8 defaults for Node.js #####
4343

Collapse file

‎deps/v8/src/compiler/turboshaft/index.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/compiler/turboshaft/index.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ class ConstOrV {
480480
template <typename U,
481481
typename = std::enable_if_t<std::is_constructible_v<V<T>, V<U>>>>
482482
ConstOrV(V<U> index) // NOLINT(runtime/explicit)
483-
: constant_value_(), value_(index) {}
483+
: constant_value_(std::nullopt), value_(index) {}
484484

485485
bool is_constant() const { return constant_value_.has_value(); }
486486
constant_type constant_value() const {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.