Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit faa40c3

Browse filesBrowse files
committed
doc: mention where to push security commits
PR-URL: #44691 Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 48b1ad4 commit faa40c3
Copy full SHA for faa40c3

File tree

Expand file treeCollapse file tree

1 file changed

+16
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+16
-0
lines changed
Open diff view settings
Collapse file

‎doc/contributing/releases.md‎

Copy file name to clipboardExpand all lines: doc/contributing/releases.md
+16Lines changed: 16 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,19 @@ branch.
263263
$ git checkout -b v1.2.3-proposal upstream/v1.x-staging
264264
```
265265

266+
<details>
267+
<summary>Security release</summary>
268+
269+
When performing Security Releases, the `vN.x.x-proposal` branch should be
270+
branched off of `vN.x`.
271+
272+
```console
273+
$ git checkout -b v1.2.3-proposal upstream/v1.x
274+
git cherry-pick ... # cherry-pick nodejs-private PR commits directly into the proposal
275+
```
276+
277+
</details>
278+
266279
### 3. Update `src/node_version.h`
267280

268281
Set the version for the proposed release using the following macros, which are
@@ -458,6 +471,9 @@ Notable changes:
458471
PR-URL: TBD
459472
```
460473

474+
**Note**: Ensure to push the proposal branch to the nodejs-private repository.
475+
Otherwise, you will leak the commits before the security release.
476+
461477
</details>
462478

463479
### 6. Propose release on GitHub

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.