Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fa71543

Browse filesBrowse files
mertcanaltintargos
authored andcommitted
stream: fix util.inspect for compression/decompressionStream
PR-URL: #52283 Fixes: #52263 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent c0000f4 commit fa71543
Copy full SHA for fa71543

File tree

Expand file treeCollapse file tree

2 files changed

+43
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+43
-2
lines changed
Open diff view settings
Collapse file

‎lib/internal/webstreams/compression.js‎

Copy file name to clipboardExpand all lines: lib/internal/webstreams/compression.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class CompressionStream {
7878
}
7979

8080
[kInspect](depth, options) {
81-
customInspect(depth, options, 'CompressionStream', {
81+
return customInspect(depth, options, 'CompressionStream', {
8282
readable: this.#transform.readable,
8383
writable: this.#transform.writable,
8484
});
@@ -128,7 +128,7 @@ class DecompressionStream {
128128
}
129129

130130
[kInspect](depth, options) {
131-
customInspect(depth, options, 'DecompressionStream', {
131+
return customInspect(depth, options, 'DecompressionStream', {
132132
readable: this.#transform.readable,
133133
writable: this.#transform.writable,
134134
});
Collapse file
+41Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
// Flags: --no-warnings --expose-internals
2+
'use strict';
3+
4+
require('../common');
5+
6+
const assert = require('node:assert');
7+
const { describe, it } = require('node:test');
8+
const {
9+
CompressionStream,
10+
DecompressionStream,
11+
} = require('node:stream/web');
12+
13+
const {
14+
customInspectSymbol: kInspect,
15+
} = require('internal/util');
16+
17+
describe('DecompressionStream kInspect method', () => {
18+
it('should return a predictable inspection string with DecompressionStream', () => {
19+
const decompressionStream = new DecompressionStream('deflate');
20+
const depth = 1;
21+
const options = {};
22+
const actual = decompressionStream[kInspect](depth, options);
23+
24+
assert(actual.includes('DecompressionStream'));
25+
assert(actual.includes('ReadableStream'));
26+
assert(actual.includes('WritableStream'));
27+
});
28+
});
29+
30+
describe('CompressionStream kInspect method', () => {
31+
it('should return a predictable inspection string with CompressionStream', () => {
32+
const compressionStream = new CompressionStream('deflate');
33+
const depth = 1;
34+
const options = {};
35+
const actual = compressionStream[kInspect](depth, options);
36+
37+
assert(actual.includes('CompressionStream'));
38+
assert(actual.includes('ReadableStream'));
39+
assert(actual.includes('WritableStream'));
40+
});
41+
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.