Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f868415

Browse filesBrowse files
Matheus Marchinitargos
Matheus Marchini
authored and
targos
committed
deps: cherry-pick 804a693 from upstream V8
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) R=bmeurer@google.com, yangguo@google.com Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 PR-URL: #21855 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>
1 parent 96bb605 commit f868415
Copy full SHA for f868415

File tree

Expand file treeCollapse file tree

2 files changed

+6
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-1
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
# Reset this number to 0 on major V8 upgrades.
3030
# Increment by one for each non-official patch applied to deps/v8.
31-
'v8_embedder_string': '-node.18',
31+
'v8_embedder_string': '-node.19',
3232

3333
# Enable disassembler for `--print-code` v8 options
3434
'v8_enable_disassembler': 1,
Collapse file

‎deps/v8/tools/gen-postmortem-metadata.py‎

Copy file name to clipboardExpand all lines: deps/v8/tools/gen-postmortem-metadata.py
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,9 @@
211211
'value': 'Context::EXTENSION_INDEX' },
212212
{ 'name': 'context_min_slots',
213213
'value': 'Context::MIN_CONTEXT_SLOTS' },
214+
{ 'name': 'context_idx_embedder_data',
215+
'value': 'Internals::kContextEmbedderDataIndex' },
216+
214217

215218
{ 'name': 'namedictionaryshape_prefix_size',
216219
'value': 'NameDictionaryShape::kPrefixSize' },
@@ -231,6 +234,8 @@
231234
'value': 'SimpleNumberDictionaryShape::kPrefixSize' },
232235
{ 'name': 'simplenumberdictionaryshape_entry_size',
233236
'value': 'SimpleNumberDictionaryShape::kEntrySize' },
237+
238+
{ 'name': 'type_JSError__JS_ERROR_TYPE', 'value': 'JS_ERROR_TYPE' },
234239
];
235240

236241
#

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.