Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f854701

Browse filesBrowse files
danbevBethGriggs
danbev
authored and
BethGriggs
committed
src: include node_internals.h in node_metadata.cc
Currently, if configured --without-ssl the following compiler error will be generated: ../src/node_metadata.cc:29:12: error: use of undeclared identifier 'llhttp_version' llhttp = llhttp_version; ^ ../src/node_metadata.cc:30:17: error: use of undeclared identifier 'http_parser_version' http_parser = http_parser_version; This commit includes the node_internals.h header so that llhttp_version and http_parser_versions are always available. PR-URL: #24933 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 5a1289d commit f854701
Copy full SHA for f854701

File tree

Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Collapse file

‎src/node_metadata.cc‎

Copy file name to clipboardExpand all lines: src/node_metadata.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#include "ares.h"
33
#include "nghttp2/nghttp2ver.h"
44
#include "node.h"
5+
#include "node_internals.h"
56
#include "util.h"
67
#include "uv.h"
78
#include "v8.h"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.