Commit f79096a
src: do not cache
While `NumberOfHeapSpaces()` currently returns a constant value,
that is not strictly guaranteed by the V8 API as far as I can tell.
Therefore, caching it globally does not seem appropriate.
(The motivation here is that this squelches warnings which are
produced by concurrency debugging tooling due to the apparent
race conditions when accessing the global variable.)
PR-URL: #20971
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>NumberOfHeapSpaces() globally1 parent d84aa51 commit f79096aCopy full SHA for f79096a
File tree
Expand file treeCollapse file tree
1 file changed
+2
-4
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+2
-4
lines changedOpen diff view settings
Collapse file
+2-4Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
71 | 71 | |
72 | 72 | |
73 | 73 | |
74 | | - |
75 | | - |
76 | | - |
77 | 74 | |
78 | 75 | |
79 | 76 | |
| ||
100 | 97 | |
101 | 98 | |
102 | 99 | |
| 100 | + |
103 | 101 | |
104 | 102 | |
105 | 103 | |
| ||
153 | 151 | |
154 | 152 | |
155 | 153 | |
156 | | - |
| 154 | + |
157 | 155 | |
158 | 156 | |
159 | 157 | |
|
0 commit comments