Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f7886ab

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
test: avoid empty fixture in module test
Refactor test-module-loading to use tmpdir for its empty directory rather than using a not-actually-empty directory called "empty" in fixtures. PR-URL: #21044 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent c74c83a commit f7886ab
Copy full SHA for f7886ab

File tree

Expand file treeCollapse file tree

1 file changed

+6
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-4
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-module-loading.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-module-loading.js
+6-4Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@
2121

2222
'use strict';
2323
const common = require('../common');
24+
const tmpdir = require('../common/tmpdir');
25+
2426
const assert = require('assert');
25-
const path = require('path');
2627
const fs = require('fs');
28+
const path = require('path');
2729

2830
const backslash = /\\/g;
2931

@@ -168,9 +170,10 @@ assert.strictEqual(require('../fixtures/foo').foo, 'ok',
168170

169171
// Should not attempt to load a directory
170172
try {
171-
require('../fixtures/empty');
173+
tmpdir.refresh();
174+
require(tmpdir.path);
172175
} catch (err) {
173-
assert.strictEqual(err.message, 'Cannot find module \'../fixtures/empty\'');
176+
assert.strictEqual(err.message, `Cannot find module '${tmpdir.path}'`);
174177
}
175178

176179
{
@@ -284,7 +287,6 @@ try {
284287
'fixtures/registerExt.test': {},
285288
'fixtures/registerExt.hello.world': {},
286289
'fixtures/registerExt2.test': {},
287-
'fixtures/empty.js': {},
288290
'fixtures/module-load-order/file1': {},
289291
'fixtures/module-load-order/file2.js': {},
290292
'fixtures/module-load-order/file3.node': {},

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.