nodejs
diff --git a/Collapse file
‎src/inspector_js_api.cc‎
Copy file name to clipboardExpand all lines: src/inspector_js_api.cc
+3-1Lines changed: 3 additions & 1 deletion b/Collapse file
‎src/inspector_js_api.cc‎
Copy file name to clipboardExpand all lines: src/inspector_js_api.cc
+3-1Lines changed: 3 additions & 1 deletion
diff --git a/Collapse file
‎test/parallel/test-inspector-connect-to-main-thread.js‎
Copy file name to clipboard
+20Lines changed: 20 additions & 0 deletions b/Collapse file
‎test/parallel/test-inspector-connect-to-main-thread.js‎
Copy file name to clipboard
+20Lines changed: 20 additions & 0 deletions
@@ -123,9 +123,11 @@ class JSBindingsConnection : public AsyncWrap {
     new JSBindingsConnection(env, info.This(), callback);
   }
 
+  // See https://github.com/nodejs/node/pull/46942
   void Disconnect() {
+    BaseObjectPtr<JSBindingsConnection> strong_ref{this};
     session_.reset();
-    delete this;
+    Detach();
   }
 
   static void Disconnect(const FunctionCallbackInfo<Value>& info) {
 
@@ -0,0 +1,20 @@
+'use strict';
+const common = require('../common');
+
+common.skipIfInspectorDisabled();
+
+const { Session } = require('inspector');
+const { Worker, isMainThread, workerData } = require('worker_threads');
+
+if (!workerData) {
+  common.skipIfWorker();
+}
+
+if (isMainThread) {
+  new Worker(__filename, { workerData: {} });
+} else {
+  const session = new Session();
+  session.connectToMainThread();
+  // Do not crash
+  session.disconnect();
+}
Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,11 @@ class JSBindingsConnection : public AsyncWrap {`
`123`	`123`	`new JSBindingsConnection(env, info.This(), callback);`
`124`	`124`	`}`
`125`	`125`
	`126`	`+ // See https://github.com/nodejs/node/pull/46942`
`126`	`127`	`void Disconnect() {`
	`128`	`+ BaseObjectPtr<JSBindingsConnection> strong_ref{this};`
`127`	`129`	`session_.reset();`
`128`		`- delete this;`
	`130`	`+ Detach();`
`129`	`131`	`}`
`130`	`132`
`131`	`133`	`static void Disconnect(const FunctionCallbackInfo<Value>& info) {`