Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f6bd145

Browse filesBrowse files
legendecastargos
authored andcommitted
tools: run format-cpp on node-api test c files
PR-URL: #46694 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent a92be13 commit f6bd145
Copy full SHA for f6bd145

File tree

Expand file treeCollapse file tree

1 file changed

+11
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+11
-4
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+11-4Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1414,7 +1414,6 @@ LINT_CPP_ADDON_DOC_FILES = $(wildcard $(LINT_CPP_ADDON_DOC_FILES_GLOB))
14141414
LINT_CPP_EXCLUDE ?=
14151415
LINT_CPP_EXCLUDE += src/node_root_certs.h
14161416
LINT_CPP_EXCLUDE += $(LINT_CPP_ADDON_DOC_FILES)
1417-
LINT_CPP_EXCLUDE += $(wildcard test/js-native-api/??_*/*.cc test/js-native-api/??_*/*.h test/node-api/??_*/*.cc test/node-api/??_*/*.h)
14181417
# These files were copied more or less verbatim from V8.
14191418
LINT_CPP_EXCLUDE += src/tracing/trace_event.h src/tracing/trace_event_common.h
14201419

@@ -1434,9 +1433,7 @@ LINT_CPP_FILES = $(filter-out $(LINT_CPP_EXCLUDE), $(wildcard \
14341433
test/embedding/*.h \
14351434
test/fixtures/*.c \
14361435
test/js-native-api/*/*.cc \
1437-
test/js-native-api/*/*.h \
14381436
test/node-api/*/*.cc \
1439-
test/node-api/*/*.h \
14401437
tools/icu/*.cc \
14411438
tools/icu/*.h \
14421439
tools/code_cache/*.cc \
@@ -1445,6 +1442,16 @@ LINT_CPP_FILES = $(filter-out $(LINT_CPP_EXCLUDE), $(wildcard \
14451442
tools/snapshot/*.h \
14461443
))
14471444

1445+
FORMAT_CPP_FILES ?=
1446+
FORMAT_CPP_FILES += $(LINT_CPP_FILES)
1447+
# C source codes.
1448+
FORMAT_CPP_FILES += $(wildcard \
1449+
test/js-native-api/*/*.c \
1450+
test/js-native-api/*/*.h \
1451+
test/node-api/*/*.c \
1452+
test/node-api/*/*.h \
1453+
)
1454+
14481455
# Code blocks don't have newline at the end,
14491456
# and the actual filename is generated so it won't match header guards
14501457
ADDON_DOC_LINT_FLAGS=-whitespace/ending_newline,-build/header_guard
@@ -1473,7 +1480,7 @@ ifneq ("","$(wildcard tools/clang-format/node_modules/)")
14731480
--binary=tools/clang-format/node_modules/.bin/clang-format \
14741481
--style=file \
14751482
$(CLANG_FORMAT_START) -- \
1476-
$(LINT_CPP_FILES)
1483+
$(FORMAT_CPP_FILES)
14771484
else
14781485
$(info Required tooling for C++ code formatting is not installed.)
14791486
$(info To install (requires internet access) run: $$ make format-cpp-build)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.