Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f6655b4

Browse filesBrowse files
danbevtargos
authored andcommitted
src: remove unnecessary std::endl usage
This commit removes a few std::endl that could be replaced by '\n' as it does not look like the buffer needs to be flushed in these places. This is only done in error handling, and once when the report has been generated, so this is very minor but I thought I'd bring it up in case it was overlooked. PR-URL: #30003 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 032c23d commit f6655b4
Copy full SHA for f6655b4

File tree

Expand file treeCollapse file tree

1 file changed

+3
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-4
lines changed
Open diff view settings
Collapse file

‎src/node_report.cc‎

Copy file name to clipboardExpand all lines: src/node_report.cc
+3-4Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ std::string TriggerNodeReport(Isolate* isolate,
110110
}
111111
// Check for errors on the file open
112112
if (!outfile.is_open()) {
113-
std::cerr << std::endl
114-
<< "Failed to open Node.js report file: " << filename;
113+
std::cerr << "\nFailed to open Node.js report file: " << filename;
115114

116115
if (env != nullptr && options->report_directory.length() > 0)
117116
std::cerr << " directory: " << options->report_directory;
@@ -120,7 +119,7 @@ std::string TriggerNodeReport(Isolate* isolate,
120119
return "";
121120
}
122121
outstream = &outfile;
123-
std::cerr << std::endl << "Writing Node.js report to file: " << filename;
122+
std::cerr << "\nWriting Node.js report to file: " << filename;
124123
}
125124

126125
WriteNodeReport(isolate, env, message, trigger, filename, *outstream,
@@ -131,7 +130,7 @@ std::string TriggerNodeReport(Isolate* isolate,
131130
outfile.close();
132131
}
133132

134-
std::cerr << std::endl << "Node.js report completed" << std::endl;
133+
std::cerr << "\nNode.js report completed" << std::endl;
135134
return filename;
136135
}
137136

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.