Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f5ca39d

Browse filesBrowse files
ChALkeRMylesBorins
authored andcommitted
fs: fchmod->fchown in promises/lchown
This was a clear error. chown should do chown, not chmod. PR-URL: #20407 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jamie Davis <davisjam@vt.edu> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 0dec568 commit f5ca39d
Copy full SHA for f5ca39d

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎lib/internal/fs/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ async function lchown(path, uid, gid) {
388388
if (O_SYMLINK !== undefined) {
389389
const fd = await open(path,
390390
O_WRONLY | O_SYMLINK);
391-
return fchmod(fd, uid, gid).finally(fd.close.bind(fd));
391+
return fchown(fd, uid, gid).finally(fd.close.bind(fd));
392392
}
393393
throw new ERR_METHOD_NOT_IMPLEMENTED();
394394
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.