Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f47e8fc

Browse filesBrowse files
szmarczaktargos
authored andcommitted
test: fix DNS cancel tests
PR-URL: #44432 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent f076e72 commit f47e8fc
Copy full SHA for f47e8fc

File tree

Expand file treeCollapse file tree

2 files changed

+15
-26
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+15
-26
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-dns-channel-cancel-promise.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-dns-channel-cancel-promise.js
+8-14Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,15 @@ const dgram = require('dgram');
77
const server = dgram.createSocket('udp4');
88
const resolver = new dnsPromises.Resolver();
99

10-
const addMessageListener = () => {
11-
server.removeAllListeners('message');
12-
13-
server.once('message', () => {
14-
server.once('message', common.mustNotCall);
15-
16-
resolver.cancel();
17-
});
18-
};
19-
2010
server.bind(0, common.mustCall(async () => {
2111
resolver.setServers([`127.0.0.1:${server.address().port}`]);
2212

23-
addMessageListener();
24-
2513
// Single promise
2614
{
15+
server.once('message', () => {
16+
resolver.cancel();
17+
});
18+
2719
const hostname = 'example0.org';
2820

2921
await assert.rejects(
@@ -36,10 +28,12 @@ server.bind(0, common.mustCall(async () => {
3628
);
3729
}
3830

39-
addMessageListener();
40-
4131
// Multiple promises
4232
{
33+
server.once('message', () => {
34+
resolver.cancel();
35+
});
36+
4337
const assertions = [];
4438
const assertionCount = 10;
4539

Collapse file

‎test/parallel/test-dns-channel-cancel.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-dns-channel-cancel.js
+7-12Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,6 @@ const resolver = new Resolver();
1010
const desiredQueries = 11;
1111
let finishedQueries = 0;
1212

13-
const addMessageListener = () => {
14-
server.removeAllListeners('message');
15-
16-
server.once('message', () => {
17-
server.once('message', common.mustNotCall);
18-
19-
resolver.cancel();
20-
});
21-
};
22-
2313
server.bind(0, common.mustCall(async () => {
2414
resolver.setServers([`127.0.0.1:${server.address().port}`]);
2515

@@ -37,15 +27,20 @@ server.bind(0, common.mustCall(async () => {
3727
const next = (...args) => {
3828
callback(...args);
3929

40-
addMessageListener();
30+
server.once('message', () => {
31+
resolver.cancel();
32+
});
4133

4234
// Multiple queries
4335
for (let i = 1; i < desiredQueries; i++) {
4436
resolver.resolve4(`example${i}.org`, callback);
4537
}
4638
};
4739

40+
server.once('message', () => {
41+
resolver.cancel();
42+
});
43+
4844
// Single query
49-
addMessageListener();
5045
resolver.resolve4('example0.org', next);
5146
}));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.