Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f4777c7

Browse filesBrowse files
ofrobotsFishrock123
authored andcommitted
deps: update v8_inspector
Pick the latest v8_inspector [1] with: * V8 5.1 compatibility * Modify parse builder templates to make coverity happy * The whitespace differences in the jinja2 sub-dependency do exist upstream. I am not sure how I missed them in the original import (ed2eac). [1] pavelfeldman/v8_inspector@3b56732 PR-URL: #7118 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
1 parent 643b33b commit f4777c7
Copy full SHA for f4777c7

File tree

Expand file treeCollapse file tree

3 files changed

+16
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+16
-3
lines changed
Open diff view settings
Collapse file

‎deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py‎

Copy file name to clipboardExpand all lines: deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@ def create_primitive_type_definition(type):
180180
"integer": "int",
181181
"boolean": "bool"
182182
}
183+
defaults = {
184+
"number": "0",
185+
"integer": "0",
186+
"boolean": "false"
187+
}
183188
jsontypes = {
184189
"number": "TypeNumber",
185190
"integer": "TypeNumber",
@@ -195,6 +200,7 @@ def create_primitive_type_definition(type):
195200
"raw_type": typedefs[type],
196201
"raw_pass_type": typedefs[type],
197202
"raw_return_type": typedefs[type],
203+
"default_value": defaults[type]
198204
}
199205

200206
type_definitions = {}
Collapse file

‎deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template‎

Copy file name to clipboardExpand all lines: deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,14 @@ public:
187187
}
188188

189189
private:
190-
{{type.id}}() { }
190+
{{type.id}}()
191+
{
192+
{% for property in type.properties %}
193+
{% if not(property.optional) and "default_value" in resolve_type(property) %}
194+
m_{{property.name}} = {{resolve_type(property).default_value}};
195+
{%endif %}
196+
{% endfor %}
197+
}
191198

192199
{% for property in type.properties %}
193200
{% if property.optional %}
Collapse file

‎deps/v8_inspector/platform/v8_inspector/V8Compat.h‎

Copy file name to clipboardExpand all lines: deps/v8_inspector/platform/v8_inspector/V8Compat.h
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#include <v8.h>
99

10-
#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2)
10+
#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1)
1111
namespace v8 {
1212

1313
// In standalone V8 inspector this is expected to be noop anyways...
@@ -23,6 +23,6 @@ class V8_EXPORT MicrotasksScope {
2323

2424
} // namespace v8
2525

26-
#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2)
26+
#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1)
2727

2828
#endif // V8Compat_h

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.