Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f412b1f

Browse filesBrowse files
weyj4MylesBorins
authored andcommitted
test: clean up domain-no-error-handler test
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
1 parent 14c28eb commit f412b1f
Copy full SHA for f412b1f

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-domain-no-error-handler-abort-on-uncaught.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-domain-no-error-handler-abort-on-uncaught.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const tests = [
5858
d.run(function() {
5959
setTimeout(function() {
6060
throw new Error('boom!');
61-
});
61+
}, 1);
6262
});
6363
},
6464

@@ -87,7 +87,7 @@ const tests = [
8787

8888
d.run(function() {
8989
var fs = require('fs');
90-
fs.exists('/non/existing/file', function onExists(exists) {
90+
fs.exists('/non/existing/file', function onExists() {
9191
throw new Error('boom!');
9292
});
9393
});
@@ -104,7 +104,7 @@ const tests = [
104104
d2.run(function() {
105105
setTimeout(function() {
106106
throw new Error('boom!');
107-
});
107+
}, 1);
108108
});
109109
});
110110
},
@@ -151,7 +151,7 @@ const tests = [
151151
d.run(function() {
152152
d2.run(function() {
153153
var fs = require('fs');
154-
fs.exists('/non/existing/file', function onExists(exists) {
154+
fs.exists('/non/existing/file', function onExists() {
155155
throw new Error('boom!');
156156
});
157157
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.