Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f2ce8e0

Browse filesBrowse files
legendecasruyadorno
legendecas
authored and
ruyadorno
committed
test: define NAPI_VERSION before including node_api.h
Include node.h first to define NAPI_VERSION that node binary is built with. The node.h should also be included first in embedder's use case since it is the primary header file. PR-URL: #48376 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 13ac0a5 commit f2ce8e0
Copy full SHA for f2ce8e0

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Open diff view settings
Collapse file

‎test/cctest/test_linked_binding.cc‎

Copy file name to clipboardExpand all lines: test/cctest/test_linked_binding.cc
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
// Include node.h first to define NAPI_VERSION built with the
2+
// binary.
3+
// The node.h should also be included first in embedder's use case.
4+
#include "node.h"
15
#include "node_api.h"
26
#include "node_test_fixture.h"
37

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.