Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f217b2d

Browse filesBrowse files
committed
repl: remove deprecated repl.turnOffEditorMode() function
This function is deprecated for multiple years and provides very little benefit to users. Thus, it's removed to improve the maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent a1bcad8 commit f217b2d
Copy full SHA for f217b2d

File tree

Expand file treeCollapse file tree

3 files changed

+4
-20
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+4
-20
lines changed
Open diff view settings
Collapse file

‎doc/api/deprecations.md‎

Copy file name to clipboardExpand all lines: doc/api/deprecations.md
+4-1Lines changed: 4 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1628,12 +1628,15 @@ supported API.
16281628
### DEP0078: `REPLServer.turnOffEditorMode()`
16291629
<!-- YAML
16301630
changes:
1631+
- version: REPLACEME
1632+
pr-url: https://github.com/nodejs/node/pull/33286
1633+
description: End-of-Life.
16311634
- version: v9.0.0
16321635
pr-url: https://github.com/nodejs/node/pull/15136
16331636
description: Runtime deprecation.
16341637
-->
16351638
1636-
Type: Runtime
1639+
Type: End-of-Life
16371640
16381641
`REPLServer.turnOffEditorMode()` was removed from userland visibility.
16391642
Collapse file

‎lib/repl.js‎

Copy file name to clipboardExpand all lines: lib/repl.js
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,11 +1034,6 @@ REPLServer.prototype.setPrompt = function setPrompt(prompt) {
10341034
Interface.prototype.setPrompt.call(this, prompt);
10351035
};
10361036

1037-
REPLServer.prototype.turnOffEditorMode = deprecate(
1038-
function() { _turnOffEditorMode(this); },
1039-
'REPLServer.turnOffEditorMode() is deprecated',
1040-
'DEP0078');
1041-
10421037
const requireRE = /\brequire\s*\(\s*['"`](([\w@./-]+\/)?(?:[\w@./-]*))(?![^'"`])$/;
10431038
const fsAutoCompleteRE = /fs(?:\.promises)?\.\s*[a-z][a-zA-Z]+\(\s*["'](.*)/;
10441039
const simpleExpressionRE =
Collapse file

‎test/parallel/test-repl-turn-off-editor-mode.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-repl-turn-off-editor-mode.js
-14Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.