Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f14775e

Browse filesBrowse files
Trottaddaleax
authored andcommitted
build: add benchmark tests to CI runs
Closes: #34321 PR-URL: #34288 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
1 parent 17973b7 commit f14775e
Copy full SHA for f14775e

File tree

Expand file treeCollapse file tree

3 files changed

+7
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+7
-3
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run a
491491

492492
# CI_* variables should be kept synchronized with the ones in vcbuild.bat
493493
CI_NATIVE_SUITES ?= addons js-native-api node-api
494-
CI_JS_SUITES ?= default
494+
CI_JS_SUITES ?= default benchmark
495495
ifeq ($(node_use_openssl), false)
496496
CI_DOC := doctool
497497
else
@@ -524,7 +524,7 @@ test-ci-js: | clear-stalled
524524
.PHONY: test-ci
525525
# Related CI jobs: most CI tests, excluding node-test-commit-arm-fanned
526526
test-ci: LOGLEVEL := info
527-
test-ci: | clear-stalled build-addons build-js-native-api-tests build-node-api-tests doc-only
527+
test-ci: | clear-stalled bench-addons-build build-addons build-js-native-api-tests build-node-api-tests doc-only
528528
out/Release/cctest --gtest_output=xml:out/junit/cctest.xml
529529
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
530530
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
Collapse file

‎test/benchmark/benchmark.status‎

Copy file name to clipboardExpand all lines: test/benchmark/benchmark.status
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,7 @@ prefix benchmark
1919
[$system==aix]
2020

2121
[$arch==arm]
22+
# https://github.com/nodejs/node/issues/34266
23+
test-benchmark-fs: SKIP
24+
# https://github.com/nodejs/build/issues/2382
25+
test-benchmark-napi: SKIP
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ cd %~dp0
1717

1818
@rem CI_* variables should be kept synchronized with the ones in Makefile
1919
set CI_NATIVE_SUITES=addons js-native-api node-api
20-
set CI_JS_SUITES=default
20+
set CI_JS_SUITES=default benchmark
2121
set CI_DOC=doctool
2222
@rem Same as the test-ci target in Makefile
2323
set "common_test_suites=%CI_JS_SUITES% %CI_NATIVE_SUITES% %CI_DOC%&set build_addons=1&set build_js_native_api_tests=1&set build_node_api_tests=1"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.