Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f0fb1d4

Browse filesBrowse files
joyeecheunggibfahn
authored andcommitted
build: enforce order of dependency when building addons
PR-URL: #17048 Fixes: #17043 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent ff1da17 commit f0fb1d4
Copy full SHA for f0fb1d4

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ test/addons/.buildstamp: config.gypi \
319319
# .buildstamp is out of date and need a rebuild.
320320
# Just goes to show that recursive make really is harmful...
321321
# TODO(bnoordhuis) Force rebuild after gyp update.
322-
build-addons: $(NODE_EXE) test/addons/.buildstamp
322+
build-addons: | $(NODE_EXE) test/addons/.buildstamp
323323

324324
ADDONS_NAPI_BINDING_GYPS := \
325325
$(filter-out test/addons-napi/??_*/binding.gyp, \
@@ -358,7 +358,7 @@ test/addons-napi/.buildstamp: config.gypi \
358358
# .buildstamp is out of date and need a rebuild.
359359
# Just goes to show that recursive make really is harmful...
360360
# TODO(bnoordhuis) Force rebuild after gyp or node-gyp update.
361-
build-addons-napi: $(NODE_EXE) test/addons-napi/.buildstamp
361+
build-addons-napi: | $(NODE_EXE) test/addons-napi/.buildstamp
362362

363363
clear-stalled:
364364
# Clean up any leftover processes but don't error if found.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.