Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f0e720a

Browse filesBrowse files
authored
test: add EOVERFLOW as an allowed error
in test-fs-read-promises-position-validation.mjs As stated in #50054 This looks like an oversight as test-fs-read-position-validation.mjs includes EOVERFLOW as an allowed error. Fixes #50054 PR-URL: #50128 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 971af4b commit f0e720a
Copy full SHA for f0e720a

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-fs-read-promises-position-validation.mjs‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-read-promises-position-validation.mjs
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ async function testInvalid(code, position) {
6262
await testValid(1n);
6363
await testValid(9);
6464
await testValid(9n);
65-
await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG' ]);
65+
await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG', 'EOVERFLOW']);
6666

67-
await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG' ]);
67+
await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG', 'EOVERFLOW']);
6868
await testInvalid('ERR_OUT_OF_RANGE', 2n ** 63n);
6969
await testInvalid('ERR_OUT_OF_RANGE', 2n ** 63n - BigInt(length));
7070

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.