Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ee2e641

Browse filesBrowse files
Trottrvagg
authored andcommitted
test: add Symbol test for assert.deepEqual()
The existing test never ran because typeof Symbol === 'function' and not 'symbol'. We have Symbols now so remove the check and just run the test. PR-URL: #3327 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent a89eeca commit ee2e641
Copy full SHA for ee2e641

File tree

Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-assert.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert.js
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,7 @@ assert.throws(makeBlock(a.deepEqual, 'a', ['a']), a.AssertionError);
140140
assert.throws(makeBlock(a.deepEqual, 'a', {0: 'a'}), a.AssertionError);
141141
assert.throws(makeBlock(a.deepEqual, 1, {}), a.AssertionError);
142142
assert.throws(makeBlock(a.deepEqual, true, {}), a.AssertionError);
143-
if (typeof Symbol === 'symbol') {
144-
assert.throws(makeBlock(assert.deepEqual, Symbol(), {}), a.AssertionError);
145-
}
143+
assert.throws(makeBlock(a.deepEqual, Symbol(), {}), a.AssertionError);
146144

147145
// primitive wrappers and object
148146
assert.doesNotThrow(makeBlock(a.deepEqual, new String('a'), ['a']),

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.