Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ecb78e6

Browse filesBrowse files
evanlucasgibfahn
authored andcommitted
src: fix typo in NODE_OPTIONS whitelist
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: #17369 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent dc24a78 commit ecb78e6
Copy full SHA for ecb78e6

File tree

Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3989,7 +3989,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
39893989
"--trace-sync-io",
39903990
"--force-async-hooks-checks",
39913991
"--trace-events-enabled",
3992-
"--trace-events-categories",
3992+
"--trace-event-categories",
39933993
"--track-heap-objects",
39943994
"--zero-fill-buffers",
39953995
"--v8-pool-size",
Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ expect('--track-heap-objects', 'B\n');
2323
expect('--throw-deprecation', 'B\n');
2424
expect('--zero-fill-buffers', 'B\n');
2525
expect('--v8-pool-size=10', 'B\n');
26+
expect('--trace-event-categories node', 'B\n');
2627

2728
if (common.hasCrypto) {
2829
expect('--use-openssl-ca', 'B\n');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.