Commit ec1cbbe
test_runner: fix memory leaks in runner
- Close readline interface after child process exits
Prevents accumulation of event listeners on stderr stream
- Extract watch mode event handler to named function
Allows proper cleanup when watch mode is aborted
These changes prevent unbounded memory growth in long-running
test suites and watch mode sessions.
PR-URL: #60860
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>1 parent 434fcd7 commit ec1cbbeCopy full SHA for ec1cbbe
1 file changed
+19-6Lines changed: 19 additions & 6 deletions
File tree
Expand file treeCollapse file tree
Open diff view settings
Filter options
- lib/internal/test_runner
Expand file treeCollapse file tree
Open diff view settings
Collapse file
lib/internal/test_runner/runner.js
Copy file name to clipboardExpand all lines: lib/internal/test_runner/runner.js+19-6Lines changed: 19 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
460 | 460 | |
461 | 461 | |
462 | 462 | |
| 463 | + |
| 464 | + |
| 465 | + |
463 | 466 | |
464 | 467 | |
465 | 468 | |
| ||
522 | 525 | |
523 | 526 | |
524 | 527 | |
525 | | - |
| 528 | + |
526 | 529 | |
527 | 530 | |
528 | 531 | |
| ||
563 | 566 | |
564 | 567 | |
565 | 568 | |
566 | | - |
| 569 | + |
| 570 | + |
| 571 | + |
| 572 | + |
| 573 | + |
| 574 | + |
| 575 | + |
| 576 | + |
| 577 | + |
| 578 | + |
| 579 | + |
567 | 580 | |
568 | 581 | |
569 | 582 | |
570 | 583 | |
571 | | - |
572 | | - |
573 | | - |
574 | | - |
| 584 | + |
575 | 585 | |
576 | 586 | |
577 | 587 | |
578 | 588 | |
| 589 | + |
| 590 | + |
| 591 | + |
579 | 592 | |
580 | 593 | |
581 | 594 | |
|
0 commit comments