Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit eb8f5ce

Browse filesBrowse files
richardlautargos
authored andcommitted
test: use .test domain for not found address
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: #38286 Refs: #38282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent d3bd4b4 commit eb8f5ce
Copy full SHA for eb8f5ce

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/common/internet.js‎

Copy file name to clipboardExpand all lines: test/common/internet.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const addresses = {
2424
MX_HOST: 'nodejs.org',
2525
// On some systems, .invalid returns a server failure/try again rather than
2626
// record not found. Use this to guarantee record not found.
27-
NOT_FOUND: 'come.on.fhqwhgads',
27+
NOT_FOUND: 'come.on.fhqwhgads.test',
2828
// A host with SRV records registered
2929
SRV_HOST: '_jabber._tcp.google.com',
3030
// A host with PTR records registered

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.