Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit eb7ee50

Browse filesBrowse files
edsadrItalo A. Casas
authored andcommitted
test: improve code in test-crypto-verify
* use common.mustCall to validate functions executions * use common.fail to check test fail * remove console.log * use arrow functions PR-URL: #10845 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent efa9845 commit eb7ee50
Copy full SHA for eb7ee50

File tree

Expand file treeCollapse file tree

1 file changed

+12
-16
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+12
-16
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-crypto-verify-failure.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-crypto-verify-failure.js
+12-16Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,36 +19,32 @@ const options = {
1919
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
2020
};
2121

22-
const server = tls.Server(options, function(socket) {
23-
setImmediate(function() {
24-
console.log('sending');
22+
const server = tls.Server(options, (socket) => {
23+
setImmediate(() => {
2524
verify();
26-
setImmediate(function() {
25+
setImmediate(() => {
2726
socket.destroy();
2827
});
2928
});
3029
});
3130

3231
function verify() {
33-
console.log('verify');
3432
crypto.createVerify('RSA-SHA1')
3533
.update('Test')
3634
.verify(certPem, 'asdfasdfas', 'base64');
3735
}
3836

39-
server.listen(0, function() {
37+
server.listen(0, common.mustCall(() => {
4038
tls.connect({
41-
port: this.address().port,
39+
port: server.address().port,
4240
rejectUnauthorized: false
43-
}, function() {
41+
}, common.mustCall(() => {
4442
verify();
45-
}).on('data', function(data) {
46-
console.log(data);
47-
}).on('error', function(err) {
48-
throw err;
49-
}).on('close', function() {
50-
server.close();
51-
}).resume();
52-
});
43+
}))
44+
.on('error', common.fail)
45+
.on('close', common.mustCall(() => {
46+
server.close();
47+
})).resume();
48+
}));
5349

5450
server.unref();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.