Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit eb7ec1b

Browse filesBrowse files
Nitzan Uzielydanielleadams
authored andcommitted
timers: remove flaky setInterval test
PR-URL: #37227 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent eb08afd commit eb7ec1b
Copy full SHA for eb7ec1b

File tree

Expand file treeCollapse file tree

1 file changed

+0
-22
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-22
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-timers-promisified.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-timers-promisified.js
-22Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -348,28 +348,6 @@ process.on('multipleResolves', common.mustNotCall());
348348
assert.strictEqual(loopCount, 5);
349349
}));
350350
}
351-
352-
{
353-
// Check that if we abort when we have some callbacks left,
354-
// we actually call them.
355-
const controller = new AbortController();
356-
const { signal } = controller;
357-
const delay = 10;
358-
let totalIterations = 0;
359-
const timeoutLoop = runInterval(async (iterationNumber) => {
360-
if (iterationNumber === 2) {
361-
await setTimeout(delay * 2);
362-
controller.abort();
363-
}
364-
if (iterationNumber > totalIterations) {
365-
totalIterations = iterationNumber;
366-
}
367-
}, delay, signal);
368-
369-
timeoutLoop.catch(common.mustCall(() => {
370-
assert.ok(totalIterations >= 3, `iterations was ${totalIterations} < 3`);
371-
}));
372-
}
373351
}
374352

375353
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.