Commit e9f33e3
readline: rename
Renames `options.deDupeHistory` → `options.removeHistoryDuplicates` for
`readline.createInterface(options)`.
The option name `removeHistoryDuplicates` is preferable to the
semantically identical name `deDupeHistory` because "dedupe" (short for
"deduplication") is obscure and neologistic while
`removeHistoryDuplicates` is clear, though verbose.
Updates tests and documentation for this option accordingly.
PR-URL: #11950
Ref: #2982
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>deDupeHistory option1 parent 8bd6ab7 commit e9f33e3Copy full SHA for e9f33e3
File tree
Expand file treeCollapse file tree
3 files changed
+13
-13
lines changedOpen diff view settings
Filter options
- doc/api
- lib
- test/parallel
Expand file treeCollapse file tree
3 files changed
+13
-13
lines changedOpen diff view settings
Collapse file
+3-3Lines changed: 3 additions & 3 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
363 | 363 | |
364 | 364 | |
365 | 365 | |
366 | | - |
367 | | - |
368 | | - |
| 366 | + |
| 367 | + |
| 368 | + |
369 | 369 | |
370 | 370 | |
371 | 371 | |
|
Collapse file
+4-4Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
39 | 39 | |
40 | 40 | |
41 | 41 | |
42 | | - |
| 42 | + |
43 | 43 | |
44 | 44 | |
45 | 45 | |
| ||
49 | 49 | |
50 | 50 | |
51 | 51 | |
52 | | - |
| 52 | + |
53 | 53 | |
54 | 54 | |
55 | 55 | |
| ||
82 | 82 | |
83 | 83 | |
84 | 84 | |
85 | | - |
| 85 | + |
86 | 86 | |
87 | 87 | |
88 | 88 | |
| ||
252 | 252 | |
253 | 253 | |
254 | 254 | |
255 | | - |
| 255 | + |
256 | 256 | |
257 | 257 | |
258 | 258 | |
|
Collapse file
test/parallel/test-readline-interface.js
Copy file name to clipboardExpand all lines: test/parallel/test-readline-interface.js+6-6Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
303 | 303 | |
304 | 304 | |
305 | 305 | |
306 | | - |
307 | | - |
| 306 | + |
| 307 | + |
308 | 308 | |
309 | 309 | |
310 | 310 | |
311 | 311 | |
312 | 312 | |
313 | | - |
| 313 | + |
314 | 314 | |
315 | 315 | |
316 | 316 | |
| ||
333 | 333 | |
334 | 334 | |
335 | 335 | |
336 | | - |
337 | | - |
| 336 | + |
| 337 | + |
338 | 338 | |
339 | 339 | |
340 | 340 | |
341 | 341 | |
342 | 342 | |
343 | | - |
| 343 | + |
344 | 344 | |
345 | 345 | |
346 | 346 | |
|
0 commit comments